[docs] CMake command docs say to use 0 for missing SHA512#18611
Merged
BillyONeal merged 1 commit intomicrosoft:masterfrom Jul 16, 2021
Merged
[docs] CMake command docs say to use 0 for missing SHA512#18611BillyONeal merged 1 commit intomicrosoft:masterfrom
BillyONeal merged 1 commit intomicrosoft:masterfrom
Conversation
|
|
JackBoosY
added
requires:vcpkg-team-review
Hamled
changed the title
Contributor
|
/azp run |
Contributor
|
Thank you very much for the PR correcting this oversight! LGTM. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ras0219-msft
approved these changes
Jun 24, 2021
JackBoosY
added
info:needs-maintainer-attention
Member
|
Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
This is a follow-up to the PR closing [vcpkg_download_distfile] Add condition for padding the SHA #18459 which made 0 the only value to use for
SHA512arguments which would result in showing the hash that vcpkg calculated when it didn't match.Some of the remaining documentation for vcpkg's CMake commands still directs users to put the value 1 when they do not yet know the correct hash. This PR fixes the documentation in those places that I was able to identify.
It also adds the instructions about using the value 0 to the documentation for
vcpkg_from_sourceforgebecause it did not have that line before. I believe this is correct because the code for that command uses the samevcpkg_download_distfilefunction that was changed, but I have not tested it myself.